Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http3: discard body from responses to HEAD requests #4115

Merged
merged 4 commits into from Oct 23, 2023
Merged

http3: discard body from responses to HEAD requests #4115

merged 4 commits into from Oct 23, 2023

Conversation

Glonee
Copy link
Contributor

@Glonee Glonee commented Oct 18, 2023 •
edited

fix #4097

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited

Codecov Report

Merging #4115 (bca0062) into master (b344940) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4115      +/-   ##
==========================================
+ Coverage   83.71%   83.72%   +0.01%     
==========================================
  Files         150      150              
  Lines       15415    15421       +6     
==========================================
+ Hits        12904    12910       +6     
  Misses       2012     2012              
  Partials      499      499
Files Coverage Δ
http3/response_writer.go 84.50% <100.00%> (+0.37%) ⬆️
http3/server.go 77.22% <100.00%> (+0.15%) ⬆️

marten-seemann
marten-seemann reviewed Oct 18, 2023
View reviewed changes
http3/server.go Outdated Show resolved Hide resolved
http3/response_writer.go Show resolved Hide resolved
Glonee and others added 2 commits October 18, 2023 01:18
@Glonee @marten-seemann
Update http3/server.go
3c0a2f8 
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
@Glonee
ruduce the size of responseWriter
bca0062
@marten-seemann marten-seemann changed the title http3: HEAD method should not have a body http3: discard body from responses to HEAD requests Oct 23, 2023
@marten-seemann marten-seemann merged commit 36f7fe7 into quic-go:master Oct 23, 2023
18 checks passed
@marten-seemann marten-seemann mentioned this pull request Apr 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http3: HEAD method should not have a body
2 participants
@Glonee @marten-seemann