don't spawn a new Go routine to send a Retry packet #4092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
retry-go-routine
branch
from
9938734
to
8b0c6ee
Compare
sukunrt
reviewed
Sep 25, 2023
Comment on lines
254
to
+257
| versionNegotiationQueue: make(chan receivedPacket, 4), | ||
| invalidTokenQueue: make(chan rejectedPacket, 4), | ||
| connectionRefusedQueue: make(chan rejectedPacket, 4), | ||
| retryQueue: make(chan rejectedPacket, 8), |
There was a problem hiding this comment.
NIT: Any reason for the queue lengths? I mean why is version negotiation 4 and this one is 8. Just curious about your thoughts.
There was a problem hiding this comment.
This isn't backed by any data, but I'd expect Retries to be sent more frequently than the other types of packets. #4077 will give us more insights at some point.
sukunrt
approved these changes
Sep 25, 2023
marten-seemann
force-pushed
the
connection-refused-go-routine
branch
from
f766bf1
to
eb99dd5
Compare
marten-seemann
force-pushed
the
retry-go-routine
branch
from
8b0c6ee
to
de9b392
Compare
marten-seemann
changed the base branch from
connection-refused-go-routine
to
master
Codecov Report
@@ Coverage Diff @@
## master #4092 +/- ##
==========================================
- Coverage 83.74% 83.73% -0.01%
==========================================
Files 150 150
Lines 15393 15401 +8
==========================================
+ Hits 12890 12895 +5
- Misses 2005 2008 +3
Partials 498 498
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4091.