automatically set the tls.Config.ServerName if unset #4032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for:
ClientSessionCache
. IfServerName
is unset, crypto/tls will discard the session ticket.Also saves one cloning of the
tls.Config
when usingDialAddr{Early}
.This is similar to what the standard library does: https://cs.opensource.google/go/go/+/refs/tags/go1.21.0:src/crypto/tls/tls.go;l=147-154