handshake: use the correct hash function for TLS_AES_256_GCM_SHA384 #4031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
approved these changes
Aug 16, 2023
Codecov Report
@@ Coverage Diff @@
## master #4031 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 147 147
Lines 14785 14785
=======================================
Hits 12247 12247
Misses 2037 2037
Partials 501 501 |
|
@mholt Yet another (and this time, very stupid copy-paste) bug introduced when switching to crypto/tls. Sorry for creating so much churn. Will ship v0.37.5 later today. Lesson learned: We need some interop tests with a different QUIC implementation in this repo, running in CI. |
|
No worries 😊 I don't know of any impacts our users experienced. |
marten-seemann
added a commit
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLS_AES_128_GCM_SHA256 and TLS_CHACHA20_POLY1305_SHA256 work fine, but if TLS happens to select TLS_AES_256_GCM_SHA384 during the handshake, we're deriving the wrong keys, causing a handshake failure.
Thanks to @MarcoPolo for discovering this when interop-ing with zig-libp2p.