Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore QUICConn.SendSessionTicket error if session tickets are disabled #4030

Merged
merged 1 commit into from Aug 16, 2023

Conversation

marten-seemann
Copy link
Member

This is a workaround until golang/go#62032 is resolved.

@marten-seemann marten-seemann linked an issue Aug 15, 2023 that may be closed by this pull request
@marten-seemann marten-seemann added this to the v0.38 milestone Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #4030 (a10509b) into master (70f3f44) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4030      +/-   ##
==========================================
+ Coverage   82.83%   82.85%   +0.02%     
==========================================
  Files         147      147              
  Lines       14785    14789       +4     
==========================================
+ Hits        12247    12253       +6     
+ Misses       2037     2036       -1     
+ Partials      501      500       -1     
Files Changed Coverage Δ
internal/handshake/crypto_setup.go 57.08% <100.00%> (+0.82%) ⬆️

@marten-seemann marten-seemann merged commit 1d84839 into master Aug 16, 2023
29 checks passed
@marten-seemann marten-seemann deleted the session-ticket-errors branch August 18, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibly using the wrong .SessionTicketsDisabled field
2 participants