fix handling of ACK frames serialized after CRYPTO frames #4018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
approved these changes
Aug 5, 2023
marten-seemann
force-pushed
the
ack-after-handshake-complete
branch
from
71ce36b
to
b47ab96
Compare
|
Thanks for the review @mholt! I really hope this is the last critical bug in the v0.37 release line. Turns out that switching out the underlying TLS stack (that's in fact what we did, given that the crypto/tls API is completely different (better!) from what we had in qtls) is a minefield. |
Codecov Report
@@ Coverage Diff @@
## master #4018 +/- ##
==========================================
+ Coverage 82.76% 83.10% +0.34%
==========================================
Files 147 147
Lines 14764 14872 +108
==========================================
+ Hits 12219 12359 +140
+ Misses 2042 2012 -30
+ Partials 503 501 -2
|
marten-seemann
force-pushed
the
ack-after-handshake-complete
branch
from
b47ab96
to
c239066
Compare
marten-seemann
added a commit
that referenced
this pull request
Aug 5, 2023
marten-seemann
added a commit
that referenced
this pull request
Aug 5, 2023
marten-seemann
commented
Aug 5, 2023
| @@ -1724,6 +1743,7 @@ func (s *connection) checkTransportParameters(params *wire.TransportParameters) | |||
|
|
|||
| func (s *connection) applyTransportParameters() { | |||
| params := s.peerParams | |||
| fmt.Println("apply transport parameters", s.config.MaxIdleTimeout, params.MaxIdleTimeout) | |||
There was a problem hiding this comment.
Leftover debug statement. Merged via this PR, then fix using force-push on master. Sorry for that.
marten-seemann
added a commit
that referenced
this pull request
Aug 5, 2023
|
Thank you @marten-seemann -- absolutely understandable and no worries :) We have released Caddy 2.7.3 with the patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.