Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire: always set the QUIC bit for Version Negotiation packets #3991

Merged
merged 2 commits into from Aug 21, 2023

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Jul 22, 2023

Let's wait for a conclusion of the mailing list discussion before merging this: https://mailarchive.ietf.org/arch/msg/quic/oR4kxGKY6mjtPC1CZegY1ED4beg/

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #3991 (50df246) into master (469a615) will increase coverage by 2.19%.
Report is 31 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3991      +/-   ##
==========================================
+ Coverage   82.86%   85.05%   +2.19%     
==========================================
  Files         146      147       +1     
  Lines       14729    15666     +937     
==========================================
+ Hits        12204    13324    +1120     
+ Misses       2025     1865     -160     
+ Partials      500      477      -23     
Files Changed Coverage Δ
internal/wire/version_negotiation.go 92.31% <100.00%> (+0.64%) ⬆️

... and 20 files with indirect coverage changes

@marten-seemann marten-seemann added this to the v0.38 milestone Aug 14, 2023
Copy link
Member Author

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a lot of discussion happening on the list.
I'm going to merge this PR since this is clearly allowed by the RFC. There's no harm to doing this, and it helps clients in certain situation.

internal/wire/version_negotiation_test.go Outdated Show resolved Hide resolved
@marten-seemann marten-seemann merged commit ced65c0 into master Aug 21, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant