Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Vue Class Component - Project Inactivity and HMR Failure #164

Closed
MatthewSH opened this issue Sep 1, 2021 · 4 comments
Closed

Vue Class Component - Project Inactivity and HMR Failure #164

MatthewSH opened this issue Sep 1, 2021 · 4 comments

Comments

@MatthewSH
Copy link

I don't think the option should be removed, however I think a warning or something should be added beside the prompt

'Class-based (https://github.com/vuejs/vue-class-component & https://github.com/kaorun343/vue-property-decorator)',

Even if it just looks like:

Class-based (https://github.com/vuejs/vue-class-component & https://github.com/kaorun343/vue-property-decorator) NOTE: HMR does not function correctly with class-based projects.

Or maybe just a new prompt as a whole to acknowledge the potential issue. It seems this bug has existed for months (reported initially in February on Quasar, then issues open on vue-class-component in late March) without acknowledgement from the devs.

For reference:
vuejs/vue-class-component#521
quasarframework/quasar#10527
quasarframework/quasar#8534

@IlCallo
Copy link
Member

IlCallo commented Sep 2, 2021

We're considering this, in case we cannot find a solution by ourselves or with Vue team support

@basurahan
Copy link

i like the class based approach hopefully it be fixed

@IlCallo
Copy link
Member

IlCallo commented Nov 4, 2021

Razvan was finally able to pin-point the problem into a vue loader bug: vuejs/vue-loader#1897
We're still going to mark Class API as deprecated, but at least the HMR problem will be fixed in next vue-loader version

@IlCallo IlCallo closed this as completed Nov 4, 2021
@rstoenescu
Copy link
Member

Seems that my PR has been merged and the vue-loader team has released a new version.
So upgraded to the new vue-loader in "@quasar/app" v3.1.9 -- highly recommended for those using the Class API.

Enjoy!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants