OpenTelemetry extension traces health endpoints when a custom root-path is configured #46040
Comments
|
/cc @brunobat (opentelemetry), @jmartisk (health), @radcortez (config,opentelemetry), @xstefank (health) |
|
There is a workaround for this behaviour. |
|
I will have a look. |
|
Yeah so the ignore list is all borked:
I will have a look at what's going on. |
gsmet
added a commit
to gsmet/quarkus
that referenced
this issue
Feb 10, 2025
We already have the full path at some point so there's really no need to rebuild it once again, especially since the code was incorrect as it was adding the /q/ prefix always if it wasn't there in the path. It's perfectly valid to not have /q in the path, for instance if you set quarkus.smallrye-health.root-path to /something/else. I added a new test based on the report in addition to the ones we added recently for related fixes. Fixes quarkusio#46040
|
#46181 should fix it. |
gsmet
added a commit
to gsmet/quarkus
that referenced
this issue
Feb 11, 2025
We already have the full path at some point so there's really no need to rebuild it once again, especially since the code was incorrect as it was adding the /q/ prefix always if it wasn't there in the path. It's perfectly valid to not have /q in the path, for instance if you set quarkus.smallrye-health.root-path to /something/else. I added a new test based on the report in addition to the ones we added recently for related fixes. Fixes quarkusio#46040 (cherry picked from commit d8daa71)
gsmet
added a commit
to jmartisk/quarkus
that referenced
this issue
Feb 24, 2025
We already have the full path at some point so there's really no need to rebuild it once again, especially since the code was incorrect as it was adding the /q/ prefix always if it wasn't there in the path. It's perfectly valid to not have /q in the path, for instance if you set quarkus.smallrye-health.root-path to /something/else. I added a new test based on the report in addition to the ones we added recently for related fixes. Fixes quarkusio#46040 (cherry picked from commit d8daa71)
gsmet
added a commit
to jmartisk/quarkus
that referenced
this issue
Feb 24, 2025
We already have the full path at some point so there's really no need to rebuild it once again, especially since the code was incorrect as it was adding the /q/ prefix always if it wasn't there in the path. It's perfectly valid to not have /q in the path, for instance if you set quarkus.smallrye-health.root-path to /something/else. I added a new test based on the report in addition to the ones we added recently for related fixes. Fixes quarkusio#46040 (cherry picked from commit d8daa71)
jmartisk
pushed a commit
to jmartisk/quarkus
that referenced
this issue
Feb 27, 2025
We already have the full path at some point so there's really no need to rebuild it once again, especially since the code was incorrect as it was adding the /q/ prefix always if it wasn't there in the path. It's perfectly valid to not have /q in the path, for instance if you set quarkus.smallrye-health.root-path to /something/else. I added a new test based on the report in addition to the ones we added recently for related fixes. Fixes quarkusio#46040 (cherry picked from commit d8daa71)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Configuring a custom path for the health endpoint like:
And then invoking endpoints such as
/observe/health/live&/observe/health/readyresults in them being traced if the OpenTelemetry extension is present. It seems to ignore/observe/healthbut not sub-paths.Expected behavior
All endpoint paths under
quarkus.smallrye-health.root-pathare excluded from tracing.Actual behavior
See details above.
How to Reproduce?
git clone https://github.com/jamesnetherton/otel-non-app-path-trace.gitcd otel-non-app-path-tracemvn clean testOtelTestwill fail. It's expecting to find only one application endpoint being traced. But it finds 3 as the health endpoints are also traced.Output of
uname -aorverNo response
Output of
java -versionNo response
Quarkus version or git rev
3.18.1
Build tool (ie. output of
mvnw --versionorgradlew --version)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: