Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.17] Upgrade to Quarkus CXF 3.17.3 and Camel Quarkus to 3.17.0 #1374

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

ppalaga
Copy link
Collaborator

@ppalaga ppalaga commented Dec 6, 2024

This PR is for 3.17. There is #1373 for main.

@zbendhiba feel free to cherry-pick this to your PR for 3.17 if this one is not merged yet on Monday.

@ppalaga ppalaga changed the title Upgrade to Quarkus CXF 3.17.3 [3.17] Upgrade to Quarkus CXF 3.17.3 Dec 6, 2024

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Dec 9, 2024

@ppalaga is the CI failure fixed with Camel Quarkus 3.17.0?

@gsmet gsmet changed the title [3.17] Upgrade to Quarkus CXF 3.17.3 [3.17] Upgrade to Quarkus CXF 3.17.3 and Camel Quarkus to 3.17.0 Dec 9, 2024
@gsmet
Copy link
Member

gsmet commented Dec 9, 2024

I pushed the Camel Quarkus update here too to get a CI run of both and see if it fixes the failing test.

@zbendhiba
Copy link
Collaborator

I think I missed @ppalaga comment, unsure if I need to update something. Let's see how this latest build goes.

Copy link

quarkus-bot bot commented Dec 9, 2024

Status for workflow CI Build

This is the status report for running CI Build on commit 1cb35e0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet
Copy link
Member

gsmet commented Dec 9, 2024

Apparently CI is green so I would say we could merge.

@ppalaga
Copy link
Collaborator Author

ppalaga commented Dec 9, 2024

This one looks great and can be merged. Thanks @zbendhiba and @gsmet !

@zbendhiba
Copy link
Collaborator

@ppalaga how about the other one #1373 ?

Are they the same PR ?

@gsmet gsmet merged commit 3d86a39 into quarkusio:3.17 Dec 10, 2024
4 checks passed
@ppalaga
Copy link
Collaborator Author

ppalaga commented Dec 10, 2024

@ppalaga how about the other one #1373 ?

Are they the same PR ?

No, #1373 aims main. This one is towards 3.17. @gsmet likes getting two separate PRs (for main and x.y) once the given Platform .0 is out and the x.y branch has been forked.

@zbendhiba
Copy link
Collaborator

oh, yes! good catch!

@gsmet
Copy link
Member

gsmet commented Dec 10, 2024

@zbendhiba to clarify the process, I grouped the PR as we had a CI failure and I wanted to check it would be fixed with the new Camel Quarkus version. If CI is happy, I'm perfectly fine merging these separately.

@gsmet
Copy link
Member

gsmet commented Dec 11, 2024

@ppalaga I don't see any release notes available so I will let you add them to the upcoming blog post when you have them.

Ideally even better if I don't have to look for them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants