Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Camel Quarkus 3.8.0 #1129

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Upgrade to Camel Quarkus 3.8.0 #1129

merged 1 commit into from
Feb 27, 2024

Conversation

aldettinger
Copy link
Contributor

No description provided.

pom.xml Show resolved Hide resolved
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@aldettinger
Copy link
Contributor Author

aldettinger commented Feb 26, 2024

@gsmet After working around the Camel Quarkus failing tests, there are still a few quarkiverse tests failing:

  • io.quarkiverse.googlecloudservices.it.PubSubResourceTest.testPubSub
  • io.quarkiverse.operatorsdk.it.EmptyOperatorLevelNamespacesTest.reconcilersWithoutSpecificNamespacesShouldWatchAllNamespaces
  • io.quarkiverse.operatorsdk.it.OperatorSDKResourceTest
  • io.quarkiverse.operatorsdk.it.SetOperatorLevelNamespacesTest.dependentAnnotationsShouldAppearInConfiguration

Are these known issues ? Does it prevent from merging ?

@jamesnetherton
Copy link
Collaborator

After working around the Camel Quarkus failing tests, there are still a few quarkiverse tests failing:

@aldettinger I don't have karma to push to your branch. This may help things aldettinger#1.

@gsmet
Copy link
Member

gsmet commented Feb 27, 2024

@loicmathieu the Camel upgrade is causing upgrades to the Google libraries (see the Google BOM in the PR) and apparently it's causing some test issues. Could you have a look?

@gsmet
Copy link
Member

gsmet commented Feb 27, 2024

@metacosm do the Operator SDK failures above ring a bell?

@gsmet
Copy link
Member

gsmet commented Feb 27, 2024

I rebased to drop the merge commits. Let's see how CI goes with your latest changes.

@metacosm
Copy link
Contributor

@metacosm do the Operator SDK failures above ring a bell?

Difficult to tell without more details but QOSDK (and more generally, Fabric8 client) won't work properly with Quarkus 3.7.4 and above in native because of the commons-compress update. We have workarounds but we're hoping for a 1.26.1 release of commons-compress that should address the issue.

@loicmathieu
Copy link
Contributor

Latest version of the Google Cloud Library BOM didn't work in native, see https://github.com/quarkiverse/quarkus-google-cloud-services/actions/runs/7999885847/job/21848410829?pr=582

It may be better if Quarkus Camel would not include directly the Google Library BOM but uses the version from the Quarkus Google Cloud Services to avoid dependency divergence (this is what is done for ex for Micrometer Stackdriver). Would it be possible @jamesnetherton ?

This is not the first time that a new version of the Google Cloud Library BOM didn't work in native, I will try to get in touche with them to see how we can work together to smooth things up.

@jamesnetherton
Copy link
Collaborator

Would it be possible @jamesnetherton ?

We could try to experiment with that. I'm not sure of the best way to handle it...

Camel is eagerly updating to the latest Google Library BOM via dependabot. If I have to force downgrade and override dependencies in Camel Quarkus, it could potentially break the Camel Google components. So I'd have to downgrade the BOM version in Camel itself.

Thus we could end up in a position where neither CQ or Camel can upgrade until Quarkus Google Cloud Services has upgraded.

Maybe if we did more frequent releases of Quarkus Google Cloud Services it'd help a bit?

new version of the Google Cloud Library BOM didn't work in native

Do you remember which issue(s)? The only one I'm aware of was with BigQuery and Apache Arrow Netty being incompatible with Quarkus Netty. That is resolved in the latest releases.

@aloubyansky
Copy link
Member

@loicmathieu in case it helps, you could configure groupIds of artifacts you would like to control with ownGroupIds element, e.g. https://github.com/quarkusio/quarkus-platform/blob/main/pom.xml#L465-L467
For now there is nothing configured for the GCS member, which means it "owns" only the groupId of its quarkiverse BOM.

@loicmathieu
Copy link
Contributor

@jamesnetherton well, if it's Camel and not Camel Quarkus that upgrades the dependency, it should stay as is.

new version of the Google Cloud Library BOM didn't work in native

It's not the first time, and with the BigQuery/Arrow issue it causes crash multiple time as we had to create a substitution then remove it ...

@aloubyansky seems interested, I'll put this in my TODO list.

To unblock the issue the BOM should be downgraded to 26.29.0 or the issue shown here should be fixed: quarkiverse/quarkus-google-cloud-services#582

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 27, 2024

Status for workflow CI Build

This is the status report for running CI Build on commit a641fb4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet
Copy link
Member

gsmet commented Feb 27, 2024

Merging this but we will probably need to sort out the Google Cloud libraries situation. If Camel wants to use the latest version, they will need to contribute to the Google Cloud libraries extensions to make sure they actually work in native.

@gsmet gsmet merged commit d33c5be into quarkusio:main Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants