Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: quarkiverse/quarkus-github-app
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.8.3
Choose a base ref
...
head repository: quarkiverse/quarkus-github-app
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.8.4
Choose a head ref
  • 7 commits
  • 17 files changed
  • 2 contributors

Commits on Jan 31, 2025

  1. [maven-release-plugin] prepare for next development iteration

    @quarkiverse-ci
    quarkiverse-ci[bot] committed Jan 31, 2025
    Loading
    Loading status checks…
    Copy the full SHA
    d3ffd95 View commit details

Commits on Feb 5, 2025

  1. Drop unused parameters, fixing issue with Quarkus main branch

    @gsmet
    gsmet committed Feb 5, 2025
    Loading
    Loading status checks…

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    353b12e View commit details

  2. Merge pull request #716 from gsmet/drop-unused-paratemers 

    Drop unused parameters, fixing issue with Quarkus main branch
    @gsmet
    gsmet authored Feb 5, 2025
    Loading
    Loading status checks…
    Copy the full SHA
    1362e1f View commit details

  3. Release 2.8.4

    @gsmet
    gsmet authored Feb 5, 2025
    Loading
    Loading status checks…
    Copy the full SHA
    62a48f1 View commit details

  4. Merge pull request #717 from quarkiverse/gsmet-patch-1 

    Release 2.8.4
    @gsmet
    gsmet authored Feb 5, 2025
    Loading
    Loading status checks…
    Copy the full SHA
    cd08534 View commit details

  5. Update the latest release version 2.8.4 in documentation

    @quarkiverse-ci
    quarkiverse-ci[bot] committed Feb 5, 2025
    Copy the full SHA
    3374a2a View commit details

  6. [maven-release-plugin] prepare release 2.8.4

    @quarkiverse-ci
    quarkiverse-ci[bot] committed Feb 5, 2025
    Loading
    Loading status checks…
    Copy the full SHA
    7ba901b View commit details
2 changes: 1 addition & 1 deletion .github/project.yml
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Quarkus GitHub App
release:
current-version: 2.8.3
current-version: 2.8.4
next-version: 999-SNAPSHOT
2 changes: 1 addition & 1 deletion command-airline/deployment/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
<parent>
<groupId>io.quarkiverse.githubapp</groupId>
<artifactId>quarkus-github-app-command-airline-parent</artifactId>
<version>2.8.3</version>
<version>2.8.4</version>
<relativePath>../pom.xml</relativePath>
</parent>

2 changes: 1 addition & 1 deletion command-airline/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
<parent>
<groupId>io.quarkiverse.githubapp</groupId>
<artifactId>quarkus-github-app-parent</artifactId>
<version>2.8.3</version>
<version>2.8.4</version>
<relativePath>../pom.xml</relativePath>
</parent>

2 changes: 1 addition & 1 deletion command-airline/runtime/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
<parent>
<groupId>io.quarkiverse.githubapp</groupId>
<artifactId>quarkus-github-app-command-airline-parent</artifactId>
<version>2.8.3</version>
<version>2.8.4</version>
<relativePath>../pom.xml</relativePath>
</parent>

2 changes: 1 addition & 1 deletion deployment/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
<parent>
<groupId>io.quarkiverse.githubapp</groupId>
<artifactId>quarkus-github-app-parent</artifactId>
<version>2.8.3</version>
<version>2.8.4</version>
<relativePath>../pom.xml</relativePath>
</parent>

6 changes: 1 addition & 5 deletions ...ment/src/main/java/io/quarkiverse/githubapp/deployment/devui/GitHubAppDevUIProcessor.java
View file
Original file line number Diff line number Diff line change
@@ -3,12 +3,10 @@
import io.quarkus.deployment.IsDevelopment;
import io.quarkus.deployment.annotations.BuildProducer;
import io.quarkus.deployment.annotations.BuildStep;
import io.quarkus.deployment.builditem.LaunchModeBuildItem;
import io.quarkus.devui.spi.page.CardPageBuildItem;
import io.quarkus.devui.spi.page.ExternalPageBuilder;
import io.quarkus.devui.spi.page.Page;
import io.quarkus.vertx.http.deployment.HttpRootPathBuildItem;
import io.quarkus.vertx.http.runtime.management.ManagementInterfaceBuildTimeConfig;

/**
* Dev UI card for displaying important details such as the GitHub App Replay UI.
@@ -17,9 +15,7 @@ public class GitHubAppDevUIProcessor {

@BuildStep(onlyIf = IsDevelopment.class)
void createDevCard(BuildProducer<CardPageBuildItem> cardPageBuildItemBuildProducer,
HttpRootPathBuildItem httpRootPathBuildItem,
ManagementInterfaceBuildTimeConfig managementInterfaceBuildTimeConfig,
LaunchModeBuildItem launchModeBuildItem) {
HttpRootPathBuildItem httpRootPathBuildItem) {
final CardPageBuildItem card = new CardPageBuildItem();

String uiPath = httpRootPathBuildItem.resolvePath("replay");
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/includes/attributes.adoc
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
:quarkus-version: 3.15.2
:quarkus-github-app-version: 2.8.3
:quarkus-github-app-version: 2.8.4

:github-api-javadoc-root-url: https://github-api.kohsuke.org/apidocs/org/kohsuke/github
:github-reference-documentation-root-url: https://docs.github.com/en/free-pro-team@latest/developers
2 changes: 1 addition & 1 deletion docs/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
<parent>
<groupId>io.quarkiverse.githubapp</groupId>
<artifactId>quarkus-github-app-parent</artifactId>
<version>2.8.3</version>
<version>2.8.4</version>
<relativePath>../pom.xml</relativePath>
</parent>

2 changes: 1 addition & 1 deletion events/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
<parent>
<groupId>io.quarkiverse.githubapp</groupId>
<artifactId>quarkus-github-app-parent</artifactId>
<version>2.8.3</version>
<version>2.8.4</version>
<relativePath>../pom.xml</relativePath>
</parent>

2 changes: 1 addition & 1 deletion integration-tests/app/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
<parent>
<groupId>io.quarkiverse.githubapp</groupId>
<artifactId>quarkus-github-app-integration-tests-parent</artifactId>
<version>2.8.3</version>
<version>2.8.4</version>
<relativePath>../pom.xml</relativePath>
</parent>

2 changes: 1 addition & 1 deletion integration-tests/command-airline/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
<parent>
<groupId>io.quarkiverse.githubapp</groupId>
<artifactId>quarkus-github-app-integration-tests-parent</artifactId>
<version>2.8.3</version>
<version>2.8.4</version>
<relativePath>../pom.xml</relativePath>
</parent>

2 changes: 1 addition & 1 deletion integration-tests/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
<parent>
<groupId>io.quarkiverse.githubapp</groupId>
<artifactId>quarkus-github-app-parent</artifactId>
<version>2.8.3</version>
<version>2.8.4</version>
<relativePath>../pom.xml</relativePath>
</parent>

2 changes: 1 addition & 1 deletion integration-tests/testing-framework/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
<parent>
<groupId>io.quarkiverse.githubapp</groupId>
<artifactId>quarkus-github-app-integration-tests-parent</artifactId>
<version>2.8.3</version>
<version>2.8.4</version>
<relativePath>../pom.xml</relativePath>
</parent>

4 changes: 2 additions & 2 deletions pom.xml
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@

<groupId>io.quarkiverse.githubapp</groupId>
<artifactId>quarkus-github-app-parent</artifactId>
<version>2.8.3</version>
<version>2.8.4</version>
<name>Quarkus - GitHub App - Parent</name>

<packaging>pom</packaging>
@@ -157,7 +157,7 @@
<url>https://github.com/quarkiverse/quarkus-github-app</url>
<connection>scm:git:git@github.com:quarkiverse/quarkus-github-app.git</connection>
<developerConnection>scm:git:git@github.com:quarkiverse/quarkus-github-app.git</developerConnection>
<tag>2.8.3</tag>
<tag>2.8.4</tag>
</scm>

<issueManagement>
2 changes: 1 addition & 1 deletion runtime/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
<parent>
<groupId>io.quarkiverse.githubapp</groupId>
<artifactId>quarkus-github-app-parent</artifactId>
<version>2.8.3</version>
<version>2.8.4</version>
<relativePath>../pom.xml</relativePath>
</parent>

2 changes: 1 addition & 1 deletion testing/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
<parent>
<groupId>io.quarkiverse.githubapp</groupId>
<artifactId>quarkus-github-app-parent</artifactId>
<version>2.8.3</version>
<version>2.8.4</version>
<relativePath>../pom.xml</relativePath>
</parent>

2 changes: 1 addition & 1 deletion ui/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
<parent>
<groupId>io.quarkiverse.githubapp</groupId>
<artifactId>quarkus-github-app-parent</artifactId>
<version>2.8.3</version>
<version>2.8.4</version>
<relativePath>../pom.xml</relativePath>
</parent>