v1.13.0 #77
Merged
v1.13.0 #77
+86
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anush008
commented
Jan 15, 2025
russcam
approved these changes
Jan 15, 2025
timvisee
reviewed
Jan 15, 2025
IvanPleshkov
requested changes
Jan 15, 2025
There was a problem hiding this comment.
I see in protofiles a new field strict_mode_config:
message UpdateCollection {
string collection_name = 1; // Name of the collection
...
optional StrictModeConfig strict_mode_config = 9; // New strict mode configuration
}
But I don't see it in QDrantClient.cs
public Task UpdateCollectionAsync(
string collectionName,
VectorParamsDiff vectorsConfig,
OptimizersConfigDiff? optimizersConfig = null,
CollectionParamsDiff? collectionParams = null,
HnswConfigDiff? hnswConfig = null,
QuantizationConfigDiff? quantizationConfig = null,
SparseVectorConfig? sparseVectorsConfig = null,
TimeSpan? timeout = null,
CancellationToken cancellationToken = default)
Signed-off-by: Anush008 <anushshetty90@gmail.com>
|
Thanks for the save Ivan. |
IvanPleshkov
approved these changes
Jan 15, 2025
Merged
Signed-off-by: Anush008 <anushshetty90@gmail.com>
timvisee
approved these changes
Jan 16, 2025
Signed-off-by: Anush008 <anushshetty90@gmail.com>
Co-authored-by: Anush <anushshetty90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the upcoming release.
Had to include 658030a to fix CI.