Allow K=1 in draw_keypoints

[haarisr]

The squeeze here makes draw keypoints not work when K=1. In my use case, I want to draw a unique color for each keypoint. So currently, I iterate over every keypoint to select a unique color i.e dim 1. The squeeze seems redundant and it should work regardless of it. There is a check on line 401 as well.

It could also be that I have not understood the comment completely.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8439

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 1 Unrelated Failure

As of commit f789651 with merge base 61d97f4 ():

NEW FAILURES - The following jobs have failed:

• CMake / macos (macos-12) / macos-job (gh)
  RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 1
• CMake / windows (windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-macos (3.10, macos-12) / macos-job (gh)
  RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 1
• Tests / unittests-macos (3.11, macos-12) / macos-job (gh)
  RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 1
• Tests / unittests-macos (3.12, macos-12) / macos-job (gh)
  RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 1
• Tests / unittests-macos (3.8, macos-12) / macos-job (gh)
  RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 1
• Tests / unittests-macos (3.9, macos-12) / macos-job (gh)
  RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 1
• Tests / unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.12, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.8, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

FLAKY - The following job failed but was likely due to flakiness present on trunk:

• Tests / unittests-windows (3.8, windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh) (matched win rule in flaky-rules.json)
  The process cannot access the file 'C:\actions-runner\_work\_actions\pytorch\test-infra\main\aws' because it is being used by another process.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

Hi @haarisr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[NicolasHug]

Thanks for the PR @haarisr .

To enable your original use-case, I feel like we should just allow colors to be a list of colors of length K, so that each keypoint could have its own color. Would that address your use-case?

[haarisr]

To enable your original use-case, I feel like we should just allow colors to be a list of colors of length K, so that each keypoint could have its own color. Would that address your use-case?

It would but we should also enable the option to draw on a single keypoint on the image? It seems counter intuitive that the function would not work in such a case.

[NicolasHug]

OK, fair enough. I slightly updated the PR so that it doesn't entirely remove the squeeze() (which is still useful) and instead only call it if the number of dimension is 3.

Thanks for the PR @haarisr , I'll merge it in a bit.