Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FBcode->GH] [codemod] Remove "using namespace" dep #8334

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

NicolasHug
Copy link
Member

Summary:
The files modified in this diff rely on using namespace in the global namespace. In this diff we break that reliance by adding appropriate namespace qualifiers.

Landing this diff helps us onboard our code to the -Wheader-hygiene warning flag.

D54681732 aggregates many of these files and D54681798 removes the associated headers; however, I have broken D54681732 up to make landing and rollbacks safer.

Reviewed By: palmje

Differential Revision: D54692584

fbshipit-source-id: 09e04b9c8f8d3d49664d33dbc2fe2f61aa8c0cfb

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…r/ThriftScannerTailer.cpp + 5

Summary:
The files modified in this diff rely on `using namespace` in the global namespace. In this diff we break that reliance by adding appropriate namespace qualifiers.

Landing this diff helps us onboard our code to the `-Wheader-hygiene` warning flag.

D54681732 aggregates many of these files and D54681798 removes the associated headers; however, I have broken D54681732 up to make landing and rollbacks safer.

Reviewed By: palmje

Differential Revision: D54692584

fbshipit-source-id: 09e04b9c8f8d3d49664d33dbc2fe2f61aa8c0cfb
Copy link

pytorch-bot bot commented Mar 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8334

Note: Links to docs will display an error until the docs builds have been completed.

❌ 16 New Failures, 20 Unrelated Failures

As of commit abba58d with merge base ef2920c (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt, thanks!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@NicolasHug NicolasHug merged commit 18a1d41 into pytorch:main Mar 20, 2024
2 of 7 checks passed
@NicolasHug NicolasHug deleted the aljenflajenfljaenf branch March 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants