Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for EXIF orientation transform in read_image for PNG #8303

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Mar 6, 2024

Description:

  • added support for EXIF orientation transform in read_image for PNG
  • restructured exif.h
  • added tests

Copy link

pytorch-bot bot commented Mar 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8303

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures, 7 Unrelated Failures

As of commit 198a3db with merge base 5501bfe (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Description:
- added support for EXIF orientation transform in read_image for PNG
- restructured exif.h
- added tests
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @vfdev-5 this looks great. I left a few Qs

Verified

This commit was signed with the committer’s verified signature.
oddgrd Oddbjørn Grødem
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @vfdev-5

vfdev-5 added 2 commits March 13, 2024 10:58
@vfdev-5 vfdev-5 merged commit bdd690e into pytorch:main Mar 13, 2024
20 of 41 checks passed
@vfdev-5 vfdev-5 deleted the exif-for-png branch March 13, 2024 10:29
facebook-github-bot pushed a commit that referenced this pull request Mar 20, 2024
…or PNG (#8303)

Reviewed By: vmoens

Differential Revision: D55062769

fbshipit-source-id: 91ee28e319746112af3b987e296852663dd1bdea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants