Fix ATen Fallback for BUILD_CAFFE2=0 for ONNX-only ops (#88504) #90104
+159
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90104
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 FailuresAs of commit 3d75c1b: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
thiagocrepaldi
requested changes
Dec 5, 2022
Follow-up for pytorch#87735 Once again, because BUILD_CAFFE2=0 is not tested for ONNX exporter, one scenario slipped through. A use case where the model can be exported without aten fallback when operator_export_type=ONNX_ATEN_FALLBACK and BUILD_CAFFE2=0 A new unit test has been added, but it won't prevent regressions if BUILD_CAFFE2=0 is not executed on CI again Fixes pytorch#87313 Pull Request resolved: pytorch#88504 Approved by: https://github.com/justinchuby, https://github.com/BowenBao (cherry picked from commit 5f0783b)
izaitsevfb
force-pushed
the
release-1.13-cherry-pick-88504
branch
from
d120586 to
e76cb2f
Compare
Co-authored-by: Thiago Crepaldi <thiago.crepaldi@microsoft.com>
atalman
reviewed
Dec 6, 2022
|
cc @thiagocrepaldi the tests is still failing even after the changes |
This is the culprit: 2022-12-06T23:11:36.7836729Z File "/var/lib/jenkins/workspace/test/onnx/test_pytorch_onnx_no_runtime.py", line 961, in test_lower_graph_conv2d
2022-12-06T23:11:36.7837274Z data_numpy = np.random.rand(1, 3, 6, 6).astype(np.float32)
2022-12-06T23:11:36.7837758Z NameError: name 'np' is not defined |
thiagocrepaldi
requested changes
Dec 7, 2022
Co-authored-by: Thiago Crepaldi <thiago.crepaldi@microsoft.com>
atalman
reviewed
Dec 7, 2022
atalman
added
ciflow/binaries
thiagocrepaldi
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick for 1.13.1 release. Original PR: #88504
Original description below:
Follow-up for #87735
Once again, because BUILD_CAFFE2=0 is not tested for ONNX exporter, one scenario slipped through. A use case where the model can be exported without aten fallback when operator_export_type=ONNX_ATEN_FALLBACK and BUILD_CAFFE2=0
A new unit test has been added, but it won't prevent regressions if BUILD_CAFFE2=0 is not executed on CI again
Fixes #87313
Pull Request resolved: #88504 Approved by: https://github.com/justinchuby, https://github.com/BowenBao
(cherry picked from commit 5f0783b)
Fixes #ISSUE_NUMBER