-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get_default_qat_qconfig for PT 1.13 #88876
Conversation
Seehttps://github.com//pull/84329/files#r1019916766 for more context
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88876
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 23c2bf0: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests to avoid such issues in the future?
@jgong5 I'm glad to add a test but I don't know where to put them. |
you can add tests here: https://github.com/pytorch/pytorch/blob/master/test/quantization/core/test_top_level_apis.py as a separate TestCase like TestQConfig or something I think, this feels like a big problem, but probably we are not using version == 0 since version defaults to 1 so it's doesn't impact current use cases much |
@jerryzh168 @jgong5 Test added. |
@pytorchmergebot merge |
Merge failedReason: Approval needed from one of the following (Rule 'superuser'): Details for Dev Infra teamRaised by workflow job |
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
See https://github.com/pytorch/pytorch/pull/84329/files#r1019916766 for more context Pull Request resolved: pytorch#88876 Approved by: https://github.com/jgong5, https://github.com/vkuzo
See https://github.com/pytorch/pytorch/pull/84329/files#r1019916766 for more context Pull Request resolved: pytorch#88876 Approved by: https://github.com/jgong5, https://github.com/vkuzo
See https://github.com/pytorch/pytorch/pull/84329/files#r1019916766 for more context Pull Request resolved: #88876 Approved by: https://github.com/jgong5, https://github.com/vkuzo Co-authored-by: peterjc123 <peterghost86@gmail.com>
See https://github.com/pytorch/pytorch/pull/84329/files#r1019916766 for more context Pull Request resolved: pytorch#88876 Approved by: https://github.com/jgong5, https://github.com/vkuzo
See https://github.com/pytorch/pytorch/pull/84329/files#r1019916766 for more context
cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel