Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DCP][AC] Add test for apply AC with FSDP1 #126935

Closed
wants to merge 1 commit into from
Closed

[DCP][AC] Add test for apply AC with FSDP1 #126935

wants to merge 1 commit into from
+20 −1

Conversation

wz337
Copy link
Contributor

@wz337 wz337 commented May 23, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot pytorch-bot bot added module: distributed_checkpoint oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category labels May 23, 2024
@wz337 wz337 marked this pull request as ready for review May 23, 2024 00:12
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126935

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d20bb53 with merge base b0e8498 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wz337 wz337 requested review from fegin and LucasLLC May 23, 2024 00:12
@wz337
Copy link
Contributor Author

wz337 commented May 23, 2024

@pytorchmergebot rebase -s

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@wz337 @pytorchmergebot
add_test_for_ac_with_FSDP1

Verified

This commit was signed with the committer’s verified signature.
Doctor-wu Doctor Wu
GPG key ID: 7D1412F015912FB2
Verified
Learn about vigilant mode
Loading
Loading status checks…
d20bb53
@pytorchmergebot
Copy link
Collaborator

Successfully rebased add_test_for_ac_with_FSDP1 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_test_for_ac_with_FSDP1 && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the add_test_for_ac_with_FSDP1 branch from 0e37092 to d20bb53 Compare May 23, 2024 03:25
fegin
fegin approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@fegin fegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test.

@wz337
Copy link
Contributor Author

wz337 commented May 23, 2024

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 23, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

wz337 added a commit to wz337/pytorch that referenced this pull request May 23, 2024
@wz337
[DCP][AC] Add test for apply AC with FSDP1 (pytorch#126935)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
b707123 
Adding test for this cherry pick. pytorch#126559

Pull Request resolved: pytorch#126935
Approved by: https://github.com/fegin
This was referenced May 23, 2024
Merged
Closed
atalman pushed a commit that referenced this pull request May 24, 2024
@wz337
[Cherry-pick][DCP][AC] Add test for apply AC with FSDP1 (#126935) (#1…
Loading
Loading status checks…
cd033a1 
…26992)

[DCP][AC] Add test for apply AC with FSDP1 (#126935)

Adding test for this cherry pick. #126559

Pull Request resolved: #126935
Approved by: https://github.com/fegin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fegin fegin

@LucasLLC LucasLLC

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wz337 @pytorchmergebot @fegin