Skip to content

Fix max_concurrent instance check and error message #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

mirceamironenco
Copy link
Contributor

Please read through our contribution guide prior to
creating your pull request.

  • If you are adding a new node, ensure you read that section in the contribution guide, as it includes requirements for
    functionality and testing.

Changes

  • I assume this check was meant to ensure that max_concurrent <= num_workers? I changed the isinstance check and modified the error message accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2025
Copy link
Contributor

@divyanshk divyanshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, looks good to me!

Copy link

pytorch-bot bot commented Jan 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1420

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5804e04 with merge base e25df94 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mirceamironenco
Copy link
Contributor Author

Is there anything needed from my side here? Seems like these are failing for an unrelated reason?

@andrewkho
Copy link
Contributor

These test failures look like they're pre-existing and unrelated, thanks for the PR
@mirceamironenco !

@andrewkho
Copy link
Contributor

Rebasing and re-starting CI

@andrewkho andrewkho merged commit 5238ca3 into pytorch:main Jan 28, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants