Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling errors in README.md for inference examples #925

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

mao3267
Copy link
Contributor

@mao3267 mao3267 commented Dec 29, 2023

Description

I am new to the PiPPy community and this is my first pr, so feel free to correct me if I am wrong.
I have corrected spelling errors and markdown format in the README.md file for inference examples.
For instance, the threshold option for split_policy. I hope that I understand it right.

Type of change

Documentation

Feature/Issue validation/testing

None

@facebook-github-bot
Copy link

Hi @Mao-Siang!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Contributor

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! And welcome to the PiPPy community!
The changes LGTM!

Ps: I want to note that the example in the inference folder needs update to work with PiPPy's new APIs. For newer examples, please refer to: examples/hf (there are ~30 HuggingFace examples here). For running ultra large models that cannot initialize on a single GPU, please refer to: examples/cpu_init

@kwen2501
Copy link
Contributor

kwen2501 commented Jan 2, 2024

Cc: @HamidShojanazeri

@kwen2501 kwen2501 merged commit e9e2d5f into pytorch:main Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants