Skip to content

Add 3rd party tests for litestar #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

provinzkraut
Copy link
Contributor

Add Litestar to the 3rd party tests.

The package relies significantly on runtime type inspections (and therefore typing-extensions 🙂), and we've been made aware that it was also affected by #560.
The issue had first been raised as a Debian bug report and was forwarded to us; An early(er) warning could have been useful to avoid this downstream issue.

The tests themselves don't take too long (~30-60 seconds), as we only need to run a subset of our test suite.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are nice and fast, the 3rd-party CI only runs once a night, and litestar is a very popular library -- so this seems pretty reasonable to me!

Each new library we add to this workflow adds a certain maintenance burden for us, as they do fail reasonably often due to changes beyond our control. I think this one meets the cost-benefit threshhold for it to be worth it, though.

@AlexWaygood
Copy link
Member

The issue had first been raised as a Debian bug report and was forwarded to us; An early(er) warning could have been useful to avoid this downstream issue.

FYI: we also publish release candidates for every typing_extensions minor release. We'd love as many downstream projects as possible to test against these, so that we're aware of breakages before they happen!

@provinzkraut
Copy link
Contributor Author

FYI: we also publish release candidates for every typing_extensions minor release. We'd love as many downstream projects as possible to test against these, so that we're aware of breakages before they happen!

Thanks for the pointer, I've added a workflow to test against typing-extension pre-releases on our side as well :)

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@JelleZijlstra JelleZijlstra merged commit 281d7b0 into python:main Apr 6, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants