Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on py312 for more third-party projects #281

Merged
merged 3 commits into from Sep 8, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Sep 8, 2023

cattrs, mypy and pyanalyze all now support Python 3.12, and run tests on Python 3.12 in CI.

Also, get rid of a hack that's no longer necessary for running the cattrs tests, since cattrs now requires Python 3.8+

@JelleZijlstra
Copy link
Member

There's something wrong with cattrs, apparently while trying to install the pendulum dependency but the error isn't very helpful.

@AlexWaygood
Copy link
Member Author

There's something wrong with cattrs, apparently while trying to install the pendulum dependency but the error isn't very helpful.

It's odd: the cattrs test suite appears to be passing on py312 upstream: https://github.com/python-attrs/cattrs/actions/runs/6043137162/job/16399595172. But they don't appear to be installing pendulum upstream; not 100% sure why we are with our invocation of the test suite.

@AlexWaygood
Copy link
Member Author

I've backed out the change for cattrs; we can leave it for now

@JelleZijlstra JelleZijlstra merged commit df9e322 into python:main Sep 8, 2023
52 checks passed
@AlexWaygood AlexWaygood deleted the more-312 branch September 8, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants