Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix third-party workflow #269

Merged
merged 1 commit into from Jul 7, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jul 7, 2023

pdm now won't let us add the main branch of typing_extensions as a dependency to pydantic or cattrs, because they both still have requires-python = ">= 3.7" in their pyproject.toml files, and we now have requires-python = ">= 3.8" in ours. To me it seems silly that pdm's locking mechanism is working this way, since we're not trying to actually install or run pydantic or cattrs on Python 3.7. But anyway, here's a hacky workaround to get things green again.

Fixes #268

@AlexWaygood
Copy link
Member Author

To me it seems silly that pdm's locking mechanism is working this way, since we're not trying to actually install or run pydantic or cattrs on Python 3.7.

Oh, I guess it's so that pip install pydantic is guaranteed to come with the same version of typing_extensions for any given version of pydantic, meaning that you get fully reproducible installs. I guess that makes sense. Still annoying for us, though.

@JelleZijlstra JelleZijlstra merged commit 7bb3f3f into python:main Jul 7, 2023
50 checks passed
@AlexWaygood AlexWaygood deleted the AlexWaygood-patch-1 branch July 7, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Third-party tests failed on Fri Jul 07 2023
2 participants