Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further simplify the implementations of the TypeVarLikes #176

Merged
merged 2 commits into from May 22, 2023
Merged

Further simplify the implementations of the TypeVarLikes #176

merged 2 commits into from May 22, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented May 22, 2023 •
edited

Use one metaclass instead of three. Do the magic in __new__ on the class instead of __call__ on the metaclass.

JelleZijlstra
JelleZijlstra approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

@JelleZijlstra JelleZijlstra merged commit 8054a29 into python:main May 22, 2023
16 checks passed
@AlexWaygood AlexWaygood deleted the Simplify branch May 22, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexWaygood @JelleZijlstra