Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a release that is working on Python 3.12.0a4 #111

Closed
hegjon opened this issue Jan 31, 2023 · 3 comments
Closed

Make a release that is working on Python 3.12.0a4 #111

hegjon opened this issue Jan 31, 2023 · 3 comments

Comments

@hegjon
Copy link
Contributor

hegjon commented Jan 31, 2023

Would it be possible to make a new release? Pull request #101 and #106 fixed issues that fails on Python 3.12.0a4.

See https://bugzilla.redhat.com/show_bug.cgi?id=2165876 for more details

@JelleZijlstra JelleZijlstra changed the title Make a relase that is working on Python 3.12.0a4 Make a release that is working on Python 3.12.0a4 Jan 31, 2023
@JelleZijlstra
Copy link
Member

I've been holding off on a release because I may want to change the behavior of @typing_extensions.deprecated. I'll hopefully get around to that in the next few days.

@hegjon
Copy link
Contributor Author

hegjon commented Feb 15, 2023

The 4.5.0 release builds (the tests runs successfully) on Python 3.12.0a5 https://copr.fedorainfracloud.org/coprs/g/python/python3.12/package/python-typing-extensions/

There are some warnings that might cause problems later:

+ /usr/bin/python3 -m unittest discover
............................................................./builddir/build/BUILD/typing_extensions-4.5.0/src/test_typing_extensions.py:242: DeprecationWarning: A will go away soon
  A(42)
...........................................sssssssssssssssssss.................................................................................Runtime type is 'object'
........................................../builddir/build/BUILD/typing_extensions-4.5.0/src/test_typing_extensions.py:1954: DeprecationWarning: The kwargs-based syntax for TypedDict definitions is deprecated in Python 3.11, will be removed in Python 3.13, and may not be understood by third-party type checkers.
  Emp = TypedDict('Emp', name=str, id=int)
......../builddir/build/BUILD/typing_extensions-4.5.0/src/test_typing_extensions.py:2061: DeprecationWarning: The kwargs-based syntax for TypedDict definitions is deprecated in Python 3.11, will be removed in Python 3.13, and may not be understood by third-party type checkers.
  EmpD = TypedDict('EmpD', name=str, id=int)
../builddir/build/BUILD/typing_extensions-4.5.0/src/test_typing_extensions.py:2039: DeprecationWarning: The kwargs-based syntax for TypedDict definitions is deprecated in Python 3.11, will be removed in Python 3.13, and may not be understood by third-party type checkers.
  EmpD = TypedDict('EmpD', name=str, id=int)
....s./builddir/build/BUILD/typing_extensions-4.5.0/src/test_typing_extensions.py:1969: DeprecationWarning: The kwargs-based syntax for TypedDict definitions is deprecated in Python 3.11, will be removed in Python 3.13, and may not be understood by third-party type checkers.
  TD = TypedDict("TD", cls=type, self=object, typename=str, _typename=int,
........
----------------------------------------------------------------------
Ran 270 tests in 0.078s

@AlexWaygood
Copy link
Member

The 4.5.0 release builds (the tests runs successfully) on Python 3.12.0a5

Thanks, looks like this has been fixed, in that case!

There are some warnings that might cause problems later:

I fixed the DeprecationWarnings and prints emitted in the test suite in #131, which will be a part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants