Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ReadOnly TypedDict items covariant #17904

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Make ReadOnly TypedDict items covariant #17904

merged 1 commit into from
Oct 9, 2024

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Oct 9, 2024

Fixes #17901.

Fixes #17901.
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Copy link
Contributor

github-actions bot commented Oct 9, 2024

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@JukkaL JukkaL merged commit e126ba0 into master Oct 9, 2024
19 checks passed
@JukkaL JukkaL deleted the readonly-covariant branch October 9, 2024 13:48
JukkaL added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadOnly TypedDict items should be treated as covariant
3 participants