Fix tests broken by hatchling #16655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
AlexWaygood
approved these changes
Dec 12, 2023
JelleZijlstra
approved these changes
Dec 12, 2023
|
If hatchling is going to roll out changes as breaking as this in minor versions then seems like we'd break often enough that pinning is worthwhile in any case. These tests are literally doing the dumbest thing ever, I'm almost tempted to write my own build backend..... |
|
Good point, tests should certainly have this kind of stuff pinned anyway |
wesleywright
pushed a commit
that referenced
this pull request
Dec 13, 2023
KotlinIsland
pushed a commit
to KotlinIsland/basedmypy
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.