Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when indexing TypedDict with empty key #15392

Merged
merged 1 commit into from Jun 8, 2023
Merged

Fix crash when indexing TypedDict with empty key #15392

merged 1 commit into from Jun 8, 2023

Conversation

hauntsaninja
Copy link
Collaborator

Fixes #15389

@hauntsaninja hauntsaninja mentioned this pull request Jun 8, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja hauntsaninja merged commit f54c309 into python:master Jun 8, 2023
20 checks passed
@hauntsaninja hauntsaninja deleted the typed-dict-crash branch June 8, 2023 04:59
@hauntsaninja hauntsaninja mentioned this pull request Jun 9, 2023
Closed
jhance pushed a commit that referenced this pull request Jun 12, 2023
@hauntsaninja @jhance
Fix crash when indexing TypedDict with empty key (#15392)
7886503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessing null key in TypedDict cause an internal error
2 participants
@hauntsaninja @JelleZijlstra