[mypyc] Support iterating over a TypedDict #14747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An optimization to make iterating over dict.keys(), dict.values() and dict.items() faster caused mypyc to crash while compiling a TypedDict. This commit fixes `Builder.get_dict_base_type` to properly handle TypedDictType.
JukkaL
reviewed
Feb 21, 2023
| @@ -50,6 +50,9 @@ class _TypedDict(Mapping[str, object]): | |||
| # Mypy expects that 'default' has a type variable type. | |||
| def pop(self, k: NoReturn, default: _T = ...) -> object: ... | |||
| def update(self: _T, __m: _T) -> None: ... | |||
| def items(self) -> dict_items[str, object]: ... | |||
| def keys(self) -> dict_keys[str, object]: ... | |||
| def values(self) -> dict_values[str, object]: ... | |||
There was a problem hiding this comment.
The return types aren't imported anywhere. For some reason we don't generate errors even though these are undefined. Maybe we are ignoring errors in test stubs?
You should be able to use a less specific type. These are adapted from mypyc test stubs:
def keys(self) -> Iterable[str]: pass
def values(self) -> Iterable[object]: pass
def items(self) -> Iterable[Tuple[str, object]]: passThere was a problem hiding this comment.
Ah, good catch! And yeah I have no idea what's up with the lack of errors. I opened an issue to note that we should investigate this later: mypyc/mypyc#976.
JukkaL
reviewed
Feb 24, 2023
| @@ -50,6 +50,9 @@ class _TypedDict(Mapping[str, object]): | |||
| # Mypy expects that 'default' has a type variable type. | |||
| def pop(self, k: NoReturn, default: _T = ...) -> object: ... | |||
| def update(self: _T, __m: _T) -> None: ... | |||
| def items(self) -> Iterable[str, object]: ... | |||
| def keys(self) -> Iterable[str, object]: ... | |||
There was a problem hiding this comment.
The return types are still invalid. It seems quite important to report errors in test stubs, as otherwise tests might not be testing what we expect them to.
JukkaL
reviewed
Mar 14, 2023
JukkaL
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An optimization to make iterating over dict.keys(), dict.values() and dict.items() faster caused mypyc to crash while compiling a TypedDict. This commit fixes
Builder.get_dict_base_typeto properly handleTypedDictType.Fixes mypyc/mypyc#869.