#1742 allowing Choropleth key_on to traverse through array

[amrutharajashekar]

closes #1742

[Conengmo]

Thanks Amrutha! I'll take a closer look shortly. Just wanted to say already it would be good to add a test for get_by_key. That would require moving it up a level so it becomes a 'proper' method on the class. Since it's not for consumption also make it private by prepending an underscore: _get_by_key.

[amrutharajashekar]

Thanks for the pointers Conengmo , will work on them over the weekend and get back to you!

[amrutharajashekar]

Hi @Conengmo How do we test for pre-commit check locally ?

[martinfleis]

@amrutharajashekar

You must first install pre-commit:

pip install pre-commit

From the root of the folium repository, you should then install the pre-commit included in Folium:

pre-commit install

Then checks will be run automatically each time you commit changes. You can skip these checks with git commit --no-verify.

[amrutharajashekar]

Hi Conengmo, I have made _get_by_key private and included the test case for the same, Please check this and let me know if any other changes are required. Thanks !

[Conengmo]

Great! I’ll take a look on Monday.

edit: it’ll be later this week, sorry

[Conengmo]

Hi @amrutharajashekar, I added a commit to your PR, hope you don't mind. Your change is good, but since we're touching this code anyway I tried to get rid of some of the repeat logic, make it a bit easier to read. I also added the 'regular' path to the test. If you are okay with this I'll go ahead and merge this one!

[amrutharajashekar]

Hi @Conengmo , I don't mind the changes made, we can go ahead and merge them 👍

[Conengmo]

@amrutharajashekar thank you very much for your help!