VectorGridProtobuf: overlay by default, add Layer arguments #1723
+30
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves: python-visualization#1716 Setting both to True allows for the use as overlay in LayerControl
|
Thanks for helping out with this @iwpnd! While testing this change, I noticed this class was not operating like a If this change also works for you we can merge it. Let me know. The pre-commit failure seems unrelated, we'll consider that separately. |
It sure is @Conengmo, thank you both pointing it out and fixing it. Will this in mind on my next contribution. 🙏 |
Conengmo
changed the title
|
@Conengmo will this be merged? |
|
yes, apologies for the delay :) thanks for your help Ben! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #1716
Setting both to
Trueallows for the use as overlay in LayerControl