Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FloatImage: use any kwargs as CSS #1668

Merged

Conversation

Conengmo
Copy link
Member

@Conengmo Conengmo commented Nov 28, 2022

Fixes #1667.

We introduced a regression in #1570 by always setting width to 100 %. At first I wanted to fix it by making the argument optional. But then, after also checking #1001 again, I opted to just open up the class to any CSS properties. With users being able to apply any CSS, we shouldn't hear about this again.

Note that this does mean an API change compared to version 0.13.0, since width will now require a unit like '%' or 'px' instead of just an integer. But I think that's a good thing. I didn't want to mess with the bottom and left parameters though, because I assume those have been around for much longer.

@Conengmo Conengmo merged commit aaf3bb6 into python-visualization:main Nov 29, 2022
@Conengmo Conengmo deleted the floatimage-arbitrary-css branch November 29, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FloatImage not working in folium v0.13.0
2 participants