Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #828
Fix an issue with Topojson object paths. With the current code each item in the path should be a valid Javascript identifier, but users may not know this.
I looked into JS identifier validation, but I don't think that's the way to go:
Instead I opted to convert the path to an array notation:
obj1.obj2
->["obj1"]["obj2"]
. After we escape double quotes any string should work. With this, object paths that include hyphens work.Alternatively, only look for hyphens and raise an error if we see one. I'd rather fix the complete problem instead of just one specific case. But if this change is too complex, that might be a small step to take instead.