Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Choropleth bins list of int #1664

Merged

Conversation

Conengmo
Copy link
Member

Closes #1130

Fix an issue in Choropleth where if bins is a list of integers, adding an inclusive right interval fails. That's because where we use np.nextafter it doesn't also convert the data type of bin_edges to float. So in practice np.nextafter does nothing there. Fix it by first converting bin_edges to an array of floats.

@Conengmo Conengmo merged commit 0b05071 into python-visualization:main Nov 27, 2022
@Conengmo Conengmo deleted the choropleth-bins-as-ints branch November 27, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexError in Choropleth when providing bins as a sequence.
1 participant