Map.show_in_browser() using temp file #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I kind of feel ashamed we never implemented that in the first place. We kind of had our heads buried deep in notebooks since day 1. Thanks for doing this! |
|
Feels pretty trivial now doesn't it :) I remember looking at #953 and not liking the amount of code, but I didn't realize yet how it could be done otherwise 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative for #953.
Related issue: #946
Allow opening a Map in the browser directly. But instead of using a server, use a temporary file instead. In functionality it should be equivalent, but the code is simpler.