Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial timestamp parameter to TimeSliderChoropleth #1435

Merged
merged 6 commits into from
Nov 10, 2022

Conversation

jjbenes
Copy link
Contributor

@jjbenes jjbenes commented Jan 11, 2021

The slider in TimeSliderChoropleth is always 0, but in some apps, I want to show the latest data first. Users can then view older data by moving the slider to the left if they want to.

Copy link
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's clear to me what you want to do, and I think we can incorporate this. I added two minor comments to possibly make the change a bit simpler.

folium/plugins/time_slider_choropleth.py Outdated Show resolved Hide resolved
folium/plugins/time_slider_choropleth.py Outdated Show resolved Hide resolved
simplified javascript and python code
@Conengmo Conengmo added the waiting for review PR is waiting to be reviewed label Jan 15, 2021
folium/plugins/time_slider_choropleth.py Show resolved Hide resolved
folium/plugins/time_slider_choropleth.py Outdated Show resolved Hide resolved
folium/plugins/time_slider_choropleth.py Outdated Show resolved Hide resolved
@Conengmo Conengmo added waiting for changes This PR has been reviewed and changes are needed before merging and removed waiting for review PR is waiting to be reviewed labels Apr 18, 2021
Co-authored-by: Frank <33519926+Conengmo@users.noreply.github.com>
@Conengmo Conengmo added waiting for review PR is waiting to be reviewed and removed waiting for changes This PR has been reviewed and changes are needed before merging labels May 6, 2022
@Conengmo Conengmo changed the title added optional inital position Add initial timestamp parameter to TimeSliderChoropleth Nov 10, 2022
@Conengmo
Copy link
Member

Conengmo commented Nov 10, 2022

Updated the PR so it works on my end and added an entry to the example notebook.

Let's merge when the tests pass.

@Conengmo Conengmo added ready PR is ready for merging and removed waiting for review PR is waiting to be reviewed labels Nov 10, 2022
@Conengmo Conengmo merged commit 0946383 into python-visualization:main Nov 10, 2022
@Conengmo
Copy link
Member

Thanks for your PR @jjbenes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR is ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants