add a gradient option to path_options #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR @nocturnalAndroid! Much appreciated. We were a bit slow with processing it, but better late than never :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaflet-dvf adds a gradient to RegularPolygonMarker by default, this change allows turning that gradient off (and also applying it to other elements like the CircleMarker which does not get it by default for some reason)
The only other reference I could find to this issue was here: #212
Though it looks like the problem raised in 2015 is not the same one referred to by the last two comments from 2020.
In any case, I've applied this fix to my local install of folium and thought I might as well submit it as a pull request, this is my first ever pull request to a public project so please let me know if I've done something wrong ¯_(ツ)_/¯