Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty geojson failing with style_function #1213

Merged
merged 5 commits into from
Nov 15, 2022
Merged

Fix empty geojson failing with style_function #1213

merged 5 commits into from
Nov 15, 2022

Conversation

agussman
Copy link
Contributor

@agussman agussman commented Oct 9, 2019 •
edited by Conengmo

Currently, attempting to plot an empty GeoJson object fails if there's a style_function. This fix checks if there are features first.

Closes #1212

stickler-ci
stickler-ci reviewed Oct 9, 2019
View reviewed changes
folium/features.py Outdated Show resolved Hide resolved
Conengmo
Conengmo requested changes Oct 29, 2019
View reviewed changes
Copy link
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for briging this bug to our attention. Let's fix it indeed. Could you address my comment and fix the CI comment about the indentation? Please also add a test that shows that using empty geojson data with a style function does not fail.

folium/features.py Outdated Show resolved Hide resolved
@Conengmo Conengmo added the waiting for changes This PR has been reviewed and changes are needed before merging label Oct 29, 2019
@Conengmo Conengmo changed the title Fix for #1212 empty geojson failing with style_function Fix empty geojson failing with style_function Nov 10, 2022
Conengmo
Conengmo approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should do it. Let's merge when the tests pass.

@Conengmo Conengmo added ready PR is ready for merging and removed waiting for changes This PR has been reviewed and changes are needed before merging labels Nov 10, 2022
@Conengmo Conengmo merged commit a0ee76e into python-visualization:main Nov 15, 2022
@Conengmo Conengmo mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stickler-ci stickler-ci stickler-ci left review comments

@Conengmo Conengmo Conengmo approved these changes

Assignees
No one assigned
Labels
ready PR is ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty geojson data fails when combined with a style_function
3 participants
@agussman @stickler-ci @Conengmo