Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 8.3 Cover & Start Timestamp #4682

Merged
merged 6 commits into from
Feb 26, 2025

Conversation

aelkheir
Copy link
Contributor

Closes #4677

  • Added the fields cover and start_timestamp to the class Video, containing a message-specific cover and a start timestamp for the video. (@aelkheir)
  • Added the parameters cover and start_timestamp to the method sendVideo, allowing bots to specify a cover and a start timestamp for the videos they send. (@aelkheir)
  • Added the fields cover and start_timestamp to the classes InputMediaVideo and InputPaidMediaVideo, allowing bots to edit video cover and start timestamp and specify them for videos in albums and paid media. (@aelkheir)
  • Added the parameter video_start_timestamp to the methods forwardMessage and copyMessage, allowing bots to change the start timestamp for forwarded and copied videos. (@aelkheir)

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- [x] Added the fields cover and `start_timestamp` to the class `Video`, containing a message-specific cover and a start timestamp for the video.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- [x] Added the parameters cover and start_timestamp to the method sendVideo,
allowing bots to specify a cover and a start timestamp for the videos they send.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- [x] Added the fields cover and start_timestamp to the classes
InputMediaVideo and InputPaidMediaVideo, allowing bots to edit video
cover and start timestamp and specify them for videos in albums and paid media.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- [x] Added the parameter video_start_timestamp to the methods
forwardMessage and copyMessage, allowing bots to change the start
timestamp for forwarded and copied videos.
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks very much for the PR! I didn't anything to comment on in the changes 🥳 The tests are failing but IISC that's due to the changes in #4676. I'll hold on the merge until we can get that fixes so that we have a clean tests run on both PRs :)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Bibo-Joshi Bibo-Joshi merged commit 9912cd1 into python-telegram-bot:api_8.3 Feb 26, 2025
20 of 23 checks passed
@Bibo-Joshi
Copy link
Member

Thank you very much for the contribution!

@aelkheir aelkheir deleted the api-8.3 branch February 27, 2025 00:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants