[FEATURE] Incorrect HTTPVersion type-alias

[antos07]

Steps to Reproduce

1. Use ApplicationBuilder().http_version("2") to enable http2, as it said in the docs

Expected behaviour

Type-checkers accept literal '2'

Actual behaviour

Type-checker complains that Literal["1.1", "2.0"] was expected.

Operating System

Debian sid

Version of Python, python-telegram-bot & dependencies

python-telegram-bot 20.4
Bot API 6.7
Python 3.11.4 (main, Jun  7 2023, 10:13:09) [GCC 12.2.0]

Relevant log output

No response

Additional Context

In telegram._utils.types it defines HTTPVersion = Literal["1.1", "2.0"]. The correct one will be HTTPVersion = Literal["1.1", "2"].

[antos07]

And I would like to fix it

[lemontree210]

Hey! Thanks for the catch! I would say it would make more sense to fix the docstring of AppBuilder.http_version. I think it's nice to have uniformity of version formats.

[lemontree210]

OTOH, I do see that HTTP 2.0 is now called HTTP/2, so maybe you're right that the literal too should have the members "1.1" and "2". Let's see what others think :)

[harshil21]

yeah, we should add "2" to the list, i.e. "1.1", "2.0" and "2"

[antos07]

Well, in fact, "2.0" isn't a valid argument and HTTPXRequest throws an exception, when I use it

[Bibo-Joshi]

That would ofc also have to be adapted :) Would you maybe like to send a PR yourself? If so, please be sure to check out our contribution guide (linked in the PR template and in the sidebar on docs.python-telegram-bot.org).

[Bibo-Joshi]

Okay, I just went ahead with it 😄 #3823