Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add OAuth2 support for OpenStreetMap #877

Merged
merged 2 commits into from Jan 30, 2024

Conversation

mmd-osm
Copy link
Contributor

@mmd-osm mmd-osm commented Jan 27, 2024

Fixes #758

Proposed changes

Adding OAuth 2.0 support for OpenStreetMap, since the existing OAuth 1.0a support will be sunset in June 2024.
Multiple applications using python-social-auth won't be able to authenticate anymore at that point.

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

Other information

I've added more details, including a screen recording, in this comment: #758 (comment)

Edits:

  • I forced-pushed the branch to include the DEFAULT_SCOPE parameter.
  • Another rebase due to "[pre-commit.ci] auto fixes from pre-commit.com hooks " being merged into master.

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22dcdaa) 77.70% compared to head (85da2df) 77.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
+ Coverage   77.70%   77.77%   +0.06%     
==========================================
  Files         345      347       +2     
  Lines       10574    10604      +30     
  Branches      699      699              
==========================================
+ Hits         8217     8247      +30     
  Misses       2200     2200              
  Partials      157      157              
Flag Coverage Δ
unittests 77.77% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nijel nijel merged commit f6d81fd into python-social-auth:master Jan 30, 2024
9 checks passed
@nijel
Copy link
Member

nijel commented Jan 30, 2024

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add OpenStreetMap OAuth2 backend
2 participants