Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync command should really add --sync option to installer #9946

Merged
merged 10 commits into from
Jan 6, 2025

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Jan 5, 2025

Pull Request Check List

Resolves: #9943

  • Added tests for changed code.
  • Updated documentation for changed code.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
trim21 Trim21
@trim21 trim21 force-pushed the sync-command-should-pass-sync branch from cfa5155 to 49c161d Compare January 5, 2025 19:25
@radoering
Copy link
Member

not sure how to test this...

You can mock installer and check that requires_synchronization is called with True.

trim21 added 2 commits January 6, 2025 03:44

Verified

This commit was signed with the committer’s verified signature.
trim21 Trim21

Verified

This commit was signed with the committer’s verified signature.
trim21 Trim21
trim21 and others added 5 commits January 6, 2025 21:00

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Bartosz Sokorski <b.sokorski@gmail.com>

Verified

This commit was signed with the committer’s verified signature.
trim21 Trim21

Verified

This commit was signed with the committer’s verified signature.
trim21 Trim21

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
radoering Randy Döring
@radoering radoering changed the title fix: sync command should real add --sync option to installer fix: sync command should really add --sync option to installer Jan 6, 2025

Verified

This commit was signed with the committer’s verified signature.
radoering Randy Döring

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@radoering radoering merged commit 4df8d63 into python-poetry:main Jan 6, 2025
73 checks passed
@trim21 trim21 deleted the sync-command-should-pass-sync branch January 12, 2025 07:43
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry sync --only=main doesn't remove package from other groups like poetry install --sync --only=main do
3 participants