Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarify error message in install #9945

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

olszewskista
Copy link
Contributor

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

In previous versions of Poetry, this was only a warning. However, the exit code has now been changed to 1, while the error message still states that it's just a warning. This inconsistency could be misleading in certain situations.

Sorry, something went wrong.

@radoering radoering enabled auto-merge (squash) January 6, 2025 04:48
@radoering radoering disabled auto-merge January 6, 2025 04:49
@radoering radoering changed the title fix: clarify error message in the install script fix: clarify error message in install Jan 6, 2025
@radoering radoering enabled auto-merge (squash) January 6, 2025 04:50
@radoering radoering merged commit d9124a8 into python-poetry:main Jan 6, 2025
73 checks passed
Copy link

github-actions bot commented Feb 6, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants