Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: improve error messages for building dependencies #7667

Merged
merged 1 commit into from Mar 18, 2023

Conversation

radoering
Copy link
Member

Pull Request Check List

Related-to: #7583 and #7498 (comment)

Improve error messages:

  • avoid improperly quoted markers in proposed command (by omitting them because they are not required)
  • better proposal for editable dependencies
  • better error message for failure during resolution of build requires
  • Added tests for changed code.
  • Updated documentation for changed code.

@radoering radoering added area/installer Related to the dependency installer impact/backport Requires backport to stable branch backport/1.4 labels Mar 17, 2023
@radoering radoering requested a review from a team March 18, 2023 14:17
@radoering radoering enabled auto-merge (squash) March 18, 2023 20:10
@radoering radoering merged commit b8e912d into python-poetry:master Mar 18, 2023
poetry-bot bot pushed a commit that referenced this pull request Mar 18, 2023
radoering added a commit that referenced this pull request Mar 18, 2023
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/installer Related to the dependency installer impact/backport Requires backport to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants