Support BGR;15, BGR;16 and BGR;24 access, unpacking and putdata #7303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
changed the title
radarhere
commented
Jul 26, 2023
| Py_DECREF(seq); | ||
| return NULL; | ||
| } | ||
| /* FIXME: what about scale and offset? */ |
There was a problem hiding this comment.
This is copying an existing FIXME
Line 1639 in 07623d1
hugovk
approved these changes
Oct 5, 2023
This was referenced Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7209 and #7260 need to exclude BGR;15, BGR;16 and BGR;24 from their tests because these modes cannot be unpacked and used with putdata.
This fixes that. It doesn't add PyAccess support though, since that is deprecated as of #7236