Fix Windows build with pyproject.toml #7230
Merged
+86
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Jun 25, 2023
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
hugovk
approved these changes
Jun 30, 2023
Comment on lines
+65
to
66
| - path: pillow\*.egg | ||
| name: egg |
There was a problem hiding this comment.
The egg format is newly deprecated on PyPI:
I know we're not uploading these, but do we need them here?
Suggested change
| - path: pillow\*.egg | |
| name: egg |
(Non-blocking for merge.)
|
Eggs can wait, let's merge so everything is ready in time for tomorrow's build. 🥚🚀 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #7190.
Closes #7190.
Two changes:
pip install -C raqm=vendor -C fribidi=vendor .instead of callingsetup.pydirectly.