Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change grabclipboard() to use PNG compression on macOS #7219

Merged
merged 3 commits into from Jun 18, 2023

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Jun 17, 2023

This PR changes grabclipboard() to use a PNG compression instead of a lossy JPG compression when reading images from he clipboard on macOS.

Fixes #7214

Before, a lossy JPG compression was used.
@radarhere
Copy link
Member

A note for the future - our tradition is to not include the CHANGES.rst updates in PRs. If something else were to be merged in first, it would create a conflict.

I've created abey79#1 with a suggestion.

@abey79
Copy link
Contributor Author

abey79 commented Jun 17, 2023

Thanks for the fix, quite the overlook on my part.

As for CHANGES.rst, it's noted. Maybe .github/CONTRIBUTING.md might be reworded? I tried to comply to the following based on recent commits I found:

  • Include release notes as needed or appropriate with your bug fixes, feature additions and tests.

@hugovk
Copy link
Member

hugovk commented Jun 18, 2023

Thanks!

@hugovk hugovk merged commit 934a6c6 into python-pillow:main Jun 18, 2023
57 of 59 checks passed
@radarhere
Copy link
Member

As for CHANGES.rst, it's noted. Maybe .github/CONTRIBUTING.md might be reworded? I tried to comply to the following based on recent commits I found:

  • Include release notes as needed or appropriate with your bug fixes, feature additions and tests.

Ok, I've created PR #7220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PIL.ImageGrab.grabclipboard() is lossy on Mac
3 participants