Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--global-option is deprecated #7167

Closed
radarhere opened this issue May 17, 2023 · 2 comments · Fixed by #7171
Closed

--global-option is deprecated #7167

radarhere opened this issue May 17, 2023 · 2 comments · Fixed by #7171
Labels
Milestone

Comments

@radarhere
Copy link
Member

https://github.com/python-pillow/Pillow/actions/runs/4999985216/jobs/8956875899#step:7:23

DEPRECATION: --build-option and --global-option are deprecated. pip 23.3 will enforce this behaviour change. A possible replacement is to use --config-settings. Discussion can be found at pypa/pip#11859

While we could possibly just remove make inplace

Pillow/Makefile

Lines 58 to 59 in 599979c

inplace: clean
python3 -m pip install -e --global-option="build_ext" --global-option="--inplace" .

and --global-option="build_ext", we do still need something to replace our build options.

The possible replacement of --config-settings would involve switching from setuptools to build.

pip releases a new version every 3 months, so pip 23.3 is due out in October, possibly before our scheduled October 15 release for Pillow 10.1. So it would be ideal to figure this out for Pillow 10.

@radarhere radarhere added this to the 10.0.0 milestone May 17, 2023
@hugovk
Copy link
Member

hugovk commented May 17, 2023

would involve switching from setuptools to build.

Sounds like a good idea. I expect this would also unblock switching from setup.cfg/setup.py to pyproject.toml, even if that can be a follow up.

pip releases a new version every 3 months, so pip 23.3 is due out in October, possibly before our scheduled October 15 release for Pillow 10.1. So it would be ideal to figure this out for Pillow 10.

👍

@radarhere
Copy link
Member Author

I've created #7171 as a possible solution. See what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants