Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with multiple apps with different translations #107

Closed
asteinlein opened this issue Jul 27, 2016 · 3 comments
Closed

Incompatible with multiple apps with different translations #107

asteinlein opened this issue Jul 27, 2016 · 3 comments

Comments

@asteinlein
Copy link

Flask-Babel stores an app instance in self.app, which will be set in init_app() regardless. This means that using the same Babel instance with multiple apps (each app running babel_instance.init_app(app) doesn't work as expected: Only the translations from the last app configured will be used.

@davidism
Copy link
Contributor

For reference, Flask-SQLAlchemy implements a get_app method and uses that anywhere an app is required.

@timothyqiu
Copy link

The same goes for localeselector and timezoneselector. They are bound to the Babel instance, so can't be configured separately for different apps 😢

FYI, Flask-SQLAlchemy and Flask-Mail store app specific states in app.extensions['NAME'].

@guydavis
Copy link

guydavis commented Jan 16, 2023

Hi, I am trying out version 3.0 that was just released and am hitting the deprecation in __init__.py of a Flask app of:

@babel.localeselector
def get_locale():
    ....

What is the recomended approach to use instead of above, to be compatible with Flask-Babel v3.0? Thanks!

EDIT: As best I can tell, before the upgrade with the old decorator, this get_locale method was getting called per-request. After the upgrade (dropping the decorator line), the method is no longer called and my app pages are no longer translated.

EDIT2: Sorry, my mistake. I found the answer digging into the diffs made to the documentation above. Leaving the answer for any others who hit this on upgrade to v3.0.

My old code:

babel = Babel(app)

@babel.localeselector
def get_locale():
    ...

Changed to work with Flask-Babel v3.0:

def get_locale():
    ...


babel = Babel(app, locale_selector=get_locale,)

ethhics added a commit to ethhics/fava that referenced this issue Feb 21, 2023
The 3.0.0 release of Babel changes the syntax for specifying a locale_selector.
In 2.x, Babel stores information only for the most recent app;
this prevents multiple apps from using the same Babel instance (see python-babel/flask-babel#107).
To add support for multiple apps, Babel 3.x moves locale selection into state,
and the previous function decoration syntax was removed.

Fortunately for fava, all this means is we need to change how we attach `get_locale()` to Babel.
It's a simple, two-line change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants